Don't copy version.dll #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to copy the original version.dll, just load it with the full path to system32.
|
Thanks, that's absolutely right and I realized that's the case some time ago too with absolute paths (as with relative or perhaps just the file name, LoadLibrary behaves like GetProcAddress if one of same name already exists), but it didn't occur to me to update it at that time... I'm gonna merge and it's gonna appear as CI artifact, but I probably won't release a v4 with just this change yet though, until some more changes appear |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to copy the original version.dll, just load it with the full path to system32.